Initial UART(E) implementation#63
Merged
Merged
Conversation
The schematic names them the wrong way around.
hargoniX
marked this pull request as ready for review
August 14, 2021 12:22
Contributor
Author
|
Currently this relies on nrf-hal upstream version since writing the example would not exactly be feasible without it, but I think it is none the less read for review and can then be merged once upstream makes a release. |
robyoung
reviewed
Aug 19, 2021
Contributor
|
Looks great, thanks! bors r+ |
Contributor
|
👎 Rejected by too few approved reviews |
robyoung
approved these changes
Aug 22, 2021
robyoung
left a comment
robyoung
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks!
bors r+
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements an abstraction for UARTE, very similar to the general I2C abstracttion. At the moment the example doesn't compile for nrf52833 yet, once nrf-rs/nrf-hal#281 is finally merged that should be fairly trivial to do though.